openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

usb: typec: silence a static checker warning 

Smatch complains about a potential missing error code:

    drivers/usb/typec/port-mapper.c:168 typec_link_port()
    warn: missing error code 'ret'

This is a false positive and returning zero is intentional.  Let's
re-arrange the code to silence the warning and make the intent more
clear.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YHadaACH8Mq/10F7@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2021-04-14 10:44:40 +03:00 committed by Greg Kroah-Hartman
parent 401411bbc4
commit 434438d8f9
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/typec/port-mapper.c
View File

@ -157,15 +157,17 @@ int typec_link_port(struct device *port)
{ {
struct device *connector; struct device *connector;
struct port_node *node; struct port_node *node;
int ret = 0; int ret;
node = create_port_node(port); node = create_port_node(port);
if (IS_ERR(node)) if (IS_ERR(node))
return PTR_ERR(node); return PTR_ERR(node);
connector = find_connector(node); connector = find_connector(node);
if (!connector) if (!connector) {
ret = 0;
goto remove_node; goto remove_node;
}
ret = link_port(to_typec_port(connector), node); ret = link_port(to_typec_port(connector), node);
if (ret) if (ret)