openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Coccinelle: limit memdup_user transformation to GFP_KERNEL case 

Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so
only allow this flag in the original code.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michal Marek <mmarek@suse.com>
This commit is contained in:
Julia Lawall 2016-09-21 17:48:39 +02:00 committed by Michal Marek
parent 29b4817d40
commit 43d96390d5
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/coccinelle/api/memdup_user.cocci
View File

@ -15,11 +15,11 @@ virtual org
virtual report
@depends on patch@
expression from,to,size,flag;
expression from,to,size;
identifier l1,l2;
@@
- to = \(kmalloc\|kzalloc\)(size,flag);
- to = \(kmalloc\|kzalloc\)(size,GFP_KERNEL);
+ to = memdup_user(from,size);
if (
- to==NULL
@ -37,12 +37,12 @@ identifier l1,l2;
- }
@r depends on !patch@
expression from,to,size,flag;
expression from,to,size;
position p;
statement S1,S2;
@@
* to = \(kmalloc@p\|kzalloc@p\)(size,flag);
* to = \(kmalloc@p\|kzalloc@p\)(size,GFP_KERNEL);
if (to==NULL || ...) S1
if (copy_from_user(to, from, size) != 0)
S2