openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

pinctrl: ti: fix error return code of ti_iodelay_probe() 

When ti_iodelay_pinconf_init_dev() fails, no error return code of
ti_iodelay_probe() is assigned.
To fix this bug, ret is assigned with the return value of
ti_iodelay_pinconf_init_dev(), and then ret is checked.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20210306125122.15043-1-baijiaju1990@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Jia-Ju Bai 2021-03-06 04:51:22 -08:00 committed by Linus Walleij
parent be786ac5a6
commit 47386ce36f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/pinctrl/ti/pinctrl-ti-iodelay.c
View File

@ -867,7 +867,8 @@ static int ti_iodelay_probe(struct platform_device *pdev)
goto exit_out;
}
if (ti_iodelay_pinconf_init_dev(iod))
ret = ti_iodelay_pinconf_init_dev(iod);
if (ret)
goto exit_out;
ret = ti_iodelay_alloc_pins(dev, iod, res->start);