openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

hwmon: (lm87) Fix masking of config register in lm87_init_client() 

lm87_init_client() conditionally sets the Start bit and clears the
INT#_Clear bit in the Config 1 register.  The condition should be that
either of these bits needs changing, but currently it checks the
(self-clearing) Initialization bit instead of INT#_Clear.

Fix the condition and also ensure we never set the Initialization bit.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
This commit is contained in:
Ben Hutchings 2008-10-17 17:51:11 +02:00 committed by Jean Delvare
parent 4b4e7a72fd
commit 49ae6cc800
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/hwmon/lm87.c
View File

@ -867,11 +867,11 @@ static void lm87_init_client(struct i2c_client *client)
lm87_write_value(client, LM87_REG_IN_MAX(0), 0xFF);
}
}
if ((config & 0x81) != 0x01) {
/* Start monitoring */
/* Make sure Start is set and INT#_Clear is clear */
if ((config & 0x09) != 0x01)
lm87_write_value(client, LM87_REG_CONFIG,
(config & 0xF7) | 0x01);
}
(config & 0x77) | 0x01);
}
static int lm87_remove(struct i2c_client *client)