openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

HSI: omap_ssi: Use devm_kcalloc() in ssi_add_controller() 

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "devm_kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
This commit is contained in:
Markus Elfring 2017-04-25 11:20:41 +02:00 committed by Sebastian Reichel
parent 34b2486def
commit 4a8557de7f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hsi/controllers/omap_ssi_core.c
View File

@ -421,8 +421,8 @@ static int ssi_add_controller(struct hsi_controller *ssi,
goto out_err; goto out_err;
} }
omap_ssi->port = devm_kzalloc(&ssi->device, omap_ssi->port = devm_kcalloc(&ssi->device, ssi->num_ports,
sizeof(struct omap_ssi_port *) * ssi->num_ports, GFP_KERNEL); sizeof(*omap_ssi->port), GFP_KERNEL);
if (!omap_ssi->port) { if (!omap_ssi->port) {
err = -ENOMEM; err = -ENOMEM;
goto out_err; goto out_err;