openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

smsc911x: Remove dev==NULL check. 

The dev==NULL check in smsc911x_probe_config is useless
and isn't providing any additional protection. If a fwnode
doesn't exist then an appropriate error should be returned
by device_get_phy_mode() covering the original case
of a missing of/fwnode.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jeremy Linton 2015-08-19 11:46:43 -05:00 committed by David S. Miller
parent 2f710a3a80
commit 4d14a63400
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/smsc/smsc911x.c
View File

@ -2370,9 +2370,6 @@ static int smsc911x_probe_config(struct smsc911x_platform_config *config,
int phy_interface;
u32 width = 0;
if (!dev)
return -ENODEV;
phy_interface = device_get_phy_mode(dev);
if (phy_interface < 0)
return phy_interface;