openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

media: i2c: adv7842: make array cri static and const, makes object smaller 

Don't populate the array 'cri' on the stack but instead make it
static and const. Makes the object code smaller by 165 bytes.

Turn the 2nd parameter of 'log_infoframe()' const accordingly.

Before:
   text	   data	    bss	    dec	    hex	filename
  98533	  20024	    256	 118813	  1d01d	drivers/media/i2c/adv7842.o

After:
   text	   data	    bss	    dec	    hex	filename
  98304	  20088	    256	 118648	  1cf78	drivers/media/i2c/adv7842.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Christophe JAILLET 2019-10-11 17:48:29 -03:00 committed by Mauro Carvalho Chehab
parent 9b950ce057
commit 4e383575a1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/i2c/adv7842.c
View File

@ -2547,7 +2547,7 @@ struct adv7842_cfg_read_infoframe {
u8 payload_addr; u8 payload_addr;
}; };
static void log_infoframe(struct v4l2_subdev *sd, struct adv7842_cfg_read_infoframe *cri) static void log_infoframe(struct v4l2_subdev *sd, const struct adv7842_cfg_read_infoframe *cri)
{ {
int i; int i;
u8 buffer[32]; u8 buffer[32];
@ -2585,7 +2585,7 @@ static void log_infoframe(struct v4l2_subdev *sd, struct adv7842_cfg_read_infofr
static void adv7842_log_infoframes(struct v4l2_subdev *sd) static void adv7842_log_infoframes(struct v4l2_subdev *sd)
{ {
int i; int i;
struct adv7842_cfg_read_infoframe cri[] = { static const struct adv7842_cfg_read_infoframe cri[] = {
{ "AVI", 0x01, 0xe0, 0x00 }, { "AVI", 0x01, 0xe0, 0x00 },
{ "Audio", 0x02, 0xe3, 0x1c }, { "Audio", 0x02, 0xe3, 0x1c },
{ "SDP", 0x04, 0xe6, 0x2a }, { "SDP", 0x04, 0xe6, 0x2a },