openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

media: ipu3-imgu: Remove dead code for NULL check 

Since ipu3_css_buf_dequeue() never returns NULL, remove the
dead code to fix static checker warning:

drivers/staging/media/ipu3/ipu3.c:493 imgu_isr_threaded()
warn: 'b' is an error pointer or valid

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
[Bug report: https://lore.kernel.org/linux-media/20190104122856.GA1169@kadam/]
Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Yong Zhi 2019-02-01 12:23:37 -05:00 committed by Mauro Carvalho Chehab
parent 041bc40662
commit 505ecd3518
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/media/ipu3/ipu3.c
View File

@ -489,12 +489,11 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)
mutex_unlock(&imgu->lock);
} while (PTR_ERR(b) == -EAGAIN);
if (IS_ERR_OR_NULL(b)) {
if (!b || PTR_ERR(b) == -EBUSY) /* All done */
break;
dev_err(&imgu->pci_dev->dev,
"failed to dequeue buffers (%ld)\n",
PTR_ERR(b));
if (IS_ERR(b)) {
if (PTR_ERR(b) != -EBUSY) /* All done */
dev_err(&imgu->pci_dev->dev,
"failed to dequeue buffers (%ld)\n",
PTR_ERR(b));
break;
}