openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

wcn36xx: fix coccinelle warnings 

drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 106
/c/kernel-tests/src/i386/drivers/net/wireless/ath/wcn36xx/debug.c:27:11-31: WARNING opportunity for simple_open, see also structure on line 148

 This removes an open coded simple_open() function
 and replaces file operations references to the function
 with simple_open() instead.

Generated by: coccinelle/api/simple_open.cocci

CC: Eugene Krasnikov <k.eugene.e@gmail.com>
CC: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Fengguang Wu 2013-10-11 23:30:26 +08:00 committed by John W. Linville
parent 7e43f3b066
commit 50d60c6322
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/wireless/ath/wcn36xx/debug.c
View File

@ -24,13 +24,6 @@
#ifdef CONFIG_WCN36XX_DEBUGFS
static int wcn36xx_debugfs_open(struct inode *inode, struct file *file)
{
file->private_data = inode->i_private;
return 0;
}
static ssize_t read_file_bool_bmps(struct file *file, char __user *user_buf,
size_t count, loff_t *ppos)
{
@ -103,7 +96,7 @@ static ssize_t write_file_bool_bmps(struct file *file,
}
static const struct file_operations fops_wcn36xx_bmps = {
.open = wcn36xx_debugfs_open,
.open = simple_open,
.read = read_file_bool_bmps,
.write = write_file_bool_bmps,
};
@ -145,7 +138,7 @@ static ssize_t write_file_dump(struct file *file,
}
static const struct file_operations fops_wcn36xx_dump = {
.open = wcn36xx_debugfs_open,
.open = simple_open,
.write = write_file_dump,
};