mirror of https://gitee.com/openkylin/linux.git
mwifiex: correctly handling kzalloc
Since kzalloc can be failed in memory pressure, it needs to be handled, otherwise NULL dereference could be happened Signed-off-by: Insu Yun <wuninsu@gmail.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
parent
9ec855cc9e
commit
50f85e220f
|
@ -2053,8 +2053,19 @@ static int mwifiex_init_sdio(struct mwifiex_adapter *adapter)
|
||||||
/* Allocate skb pointer buffers */
|
/* Allocate skb pointer buffers */
|
||||||
card->mpa_rx.skb_arr = kzalloc((sizeof(void *)) *
|
card->mpa_rx.skb_arr = kzalloc((sizeof(void *)) *
|
||||||
card->mp_agg_pkt_limit, GFP_KERNEL);
|
card->mp_agg_pkt_limit, GFP_KERNEL);
|
||||||
|
if (!card->mpa_rx.skb_arr) {
|
||||||
|
kfree(card->mp_regs);
|
||||||
|
return -ENOMEM;
|
||||||
|
}
|
||||||
|
|
||||||
card->mpa_rx.len_arr = kzalloc(sizeof(*card->mpa_rx.len_arr) *
|
card->mpa_rx.len_arr = kzalloc(sizeof(*card->mpa_rx.len_arr) *
|
||||||
card->mp_agg_pkt_limit, GFP_KERNEL);
|
card->mp_agg_pkt_limit, GFP_KERNEL);
|
||||||
|
if (!card->mpa_rx.len_arr) {
|
||||||
|
kfree(card->mp_regs);
|
||||||
|
kfree(card->mpa_rx.skb_arr);
|
||||||
|
return -ENOMEM;
|
||||||
|
}
|
||||||
|
|
||||||
ret = mwifiex_alloc_sdio_mpa_buffers(adapter,
|
ret = mwifiex_alloc_sdio_mpa_buffers(adapter,
|
||||||
card->mp_tx_agg_buf_size,
|
card->mp_tx_agg_buf_size,
|
||||||
card->mp_rx_agg_buf_size);
|
card->mp_rx_agg_buf_size);
|
||||||
|
|
Loading…
Reference in New Issue