openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

renesas: missing unlock on error path 

We need to unlock before returning here.

Fixes: a0d2f20650 ('Renesas Ethernet AVB PTP clock driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2015-06-24 17:32:54 +03:00 committed by David S. Miller
parent be35ffa38e
commit 5102e23791
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/ethernet/renesas/ravb_ptp.c
View File

@ -116,8 +116,10 @@ static int ravb_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb)
priv->ptp.current_addend = addend; priv->ptp.current_addend = addend;
gccr = ravb_read(ndev, GCCR); gccr = ravb_read(ndev, GCCR);
if (gccr & GCCR_LTI) if (gccr & GCCR_LTI) {
spin_unlock_irqrestore(&priv->lock, flags);
return -EBUSY; return -EBUSY;
}
ravb_write(ndev, addend & GTI_TIV, GTI); ravb_write(ndev, addend & GTI_TIV, GTI);
ravb_write(ndev, gccr | GCCR_LTI, GCCR); ravb_write(ndev, gccr | GCCR_LTI, GCCR);