openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

firewire net: No need to reset dev->local_fifo after failure of fw_core_add_address_handler(). 

fwnet_broadcast_start() try to register address handler at first
if it was not registered yet; dev->local_fifo ==
FWNET_NO_FIFO_ADDR.

Since dev->local_info not changed if fw_core_add_address_hander()
has failed, we do not need to set dev->local_info to
FWNET_NO_FIFO_ADDR.

Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
YOSHIFUJI Hideaki 2013-03-08 10:42:07 +09:00 committed by Stefan Richter
parent 6dbe51c251
commit 5104a03d7d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/firewire/net.c
View File

@ -1220,8 +1220,8 @@ static int fwnet_broadcast_start(struct fwnet_device *dev)
dev->broadcast_rcv_context = NULL; dev->broadcast_rcv_context = NULL;
failed_context_create: failed_context_create:
fw_core_remove_address_handler(&dev->handler); fw_core_remove_address_handler(&dev->handler);
failed_initial:
dev->local_fifo = FWNET_NO_FIFO_ADDR; dev->local_fifo = FWNET_NO_FIFO_ADDR;
failed_initial:
return retval; return retval;
} }