openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

decnet: dn_dev: Remove an unnecessary label. 

Remove the unnecessary label from dn_dev_ioctl() and make its error
handling simpler to read.

Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Suraj Upadhyay 2020-07-14 19:53:28 +05:30 committed by Jakub Kicinski
parent 94d9f78f4d
commit 514d09529d
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/decnet/dn_dev.c
View File

@ -462,7 +462,9 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg)
switch (cmd) { switch (cmd) {
case SIOCGIFADDR: case SIOCGIFADDR:
*((__le16 *)sdn->sdn_nodeaddr) = ifa->ifa_local; *((__le16 *)sdn->sdn_nodeaddr) = ifa->ifa_local;
goto rarok; if (copy_to_user(arg, ifr, DN_IFREQ_SIZE))
ret = -EFAULT;
break;
case SIOCSIFADDR: case SIOCSIFADDR:
if (!ifa) { if (!ifa) {
@ -485,10 +487,6 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg)
rtnl_unlock(); rtnl_unlock();
return ret; return ret;
rarok:
if (copy_to_user(arg, ifr, DN_IFREQ_SIZE))
ret = -EFAULT;
goto done;
} }
struct net_device *dn_dev_get_default(void) struct net_device *dn_dev_get_default(void)