openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: ethernet: cavium: liquidio: response_manager: Remove create_workqueue 

alloc_workqueue replaces deprecated create_workqueue().

A dedicated workqueue has been used since the workitem viz
(&cwq->wk.work which maps to oct_poll_req_completion) is involved
in normal device operation. WQ_MEM_RECLAIM has been set to guarantee
forward progress under memory pressure, which is a requirement here.
Since there are only a fixed number of work items, explicit concurrency
limit is unnecessary.

flush_workqueue is unnecessary since destroy_workqueue() itself calls
drain_workqueue() which flushes repeatedly till the workqueue
becomes empty. Hence the call to flush_workqueue() has been dropped.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Bhaktipriya Shridhar 2016-06-04 20:21:40 +05:30 committed by David S. Miller
parent 14de9d114a
commit 523a61b488
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/cavium/liquidio/response_manager.c
View File

@ -55,7 +55,7 @@ int octeon_setup_response_list(struct octeon_device *oct)
atomic_set(&oct->response_list[i].pending_req_count, 0); atomic_set(&oct->response_list[i].pending_req_count, 0);
} }
oct->dma_comp_wq.wq = create_workqueue("dma-comp"); oct->dma_comp_wq.wq = alloc_workqueue("dma-comp", WQ_MEM_RECLAIM, 0);
if (!oct->dma_comp_wq.wq) { if (!oct->dma_comp_wq.wq) {
dev_err(&oct->pci_dev->dev, "failed to create wq thread\n"); dev_err(&oct->pci_dev->dev, "failed to create wq thread\n");
return -ENOMEM; return -ENOMEM;
@ -72,7 +72,6 @@ int octeon_setup_response_list(struct octeon_device *oct)
void octeon_delete_response_list(struct octeon_device *oct) void octeon_delete_response_list(struct octeon_device *oct)
{ {
cancel_delayed_work_sync(&oct->dma_comp_wq.wk.work); cancel_delayed_work_sync(&oct->dma_comp_wq.wk.work);
flush_workqueue(oct->dma_comp_wq.wq);
destroy_workqueue(oct->dma_comp_wq.wq); destroy_workqueue(oct->dma_comp_wq.wq);
} }