mirror of https://gitee.com/openkylin/linux.git
IB/hfi1: Remove subtraction of uninitialized value
In process_receive_packet the packet header field is used to calculate the length of the packet. However this is not necessarily setup. In fact only if the ECN prescan is enabled will the packet header be valid at this point. The code works as is because we do not do anything with the packet length at this point in the packet processing. The length and header are setup correctly in hfi1_setup_ib_header which is called by the following sequence: process_receive_packet() -> rhf_receieve_function_map[]() --> process_receive_ib() ---> hfi1_setup_9B_packet() ----> hfi1_setup_ib_header() Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
parent
6c31e5283c
commit
52d86e72c5
|
@ -703,7 +703,6 @@ static inline int process_rcv_packet(struct hfi1_packet *packet, int thread)
|
|||
|
||||
packet->etype = rhf_rcv_type(packet->rhf);
|
||||
|
||||
packet->hlen = (u8 *)packet->rhf_addr - (u8 *)packet->hdr;
|
||||
/* total length */
|
||||
packet->tlen = rhf_pkt_len(packet->rhf); /* in bytes */
|
||||
/* retrieve eager buffer details */
|
||||
|
|
Loading…
Reference in New Issue