openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

spi/spi-pl022: Use GFP_ATOMIC for allocation from tasklet 

tasklets don't allow invocation to sleeping routines. In configure_dma()
routine, sg_alloc_table() was called with GFP_KERNEL flag and so this causes
crash when called from tasklet.

Replace GFP_KERNEL with GFP_ATOMIC to get this fixed.

Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
Viresh Kumar 2011-08-10 14:20:55 +05:30 committed by Grant Likely
parent f1e45f86ed
commit 538a18dc18
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/spi/spi-pl022.c
View File

@ -1019,11 +1019,11 @@ static int configure_dma(struct pl022 *pl022)
pages = (pl022->cur_transfer->len >> PAGE_SHIFT) + 1; pages = (pl022->cur_transfer->len >> PAGE_SHIFT) + 1;
dev_dbg(&pl022->adev->dev, "using %d pages for transfer\n", pages); dev_dbg(&pl022->adev->dev, "using %d pages for transfer\n", pages);
ret = sg_alloc_table(&pl022->sgt_rx, pages, GFP_KERNEL); ret = sg_alloc_table(&pl022->sgt_rx, pages, GFP_ATOMIC);
if (ret) if (ret)
goto err_alloc_rx_sg; goto err_alloc_rx_sg;
ret = sg_alloc_table(&pl022->sgt_tx, pages, GFP_KERNEL); ret = sg_alloc_table(&pl022->sgt_tx, pages, GFP_ATOMIC);
if (ret) if (ret)
goto err_alloc_tx_sg; goto err_alloc_tx_sg;