openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

scripts/gdb: use a generator instead of iterator for task list 

The iterator does not return any task_struct from the thread_group list
because the first condition in the 'if not t or ...' will only be the
first time None.

Instead of keeping track of the state ourself in the next() function, we
fall back using Python's generator.

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Ben Widawsky <ben@bwidawsk.net>
Cc: Borislav Petkov <bp@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Daniel Wagner 2015-02-17 13:47:41 -08:00 committed by Linus Torvalds
parent 2478a8a15c
commit 54e2289a34
1 changed files with 17 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
scripts/gdb/linux/tasks.py
View File

@ -18,38 +18,28 @@ from linux import utils
task_type = utils.CachedType("struct task_struct")
def task_lists():
global task_type
task_ptr_type = task_type.get_type().pointer()
init_task = gdb.parse_and_eval("init_task").address
t = g = init_task
class TaskList:
def __init__(self):
global task_type
self.task_ptr_type = task_type.get_type().pointer()
self.init_task = gdb.parse_and_eval("init_task")
self.curr_group = self.init_task.address
self.curr_task = None
while True:
while True:
yield t
def __iter__(self):
return self
t = utils.container_of(t['thread_group']['next'],
task_ptr_type, "thread_group")
if t == g:
break
def __next__(self):
t = self.curr_task
if not t or t == self.curr_group:
self.curr_group = \
utils.container_of(self.curr_group['tasks']['next'],
self.task_ptr_type, "tasks")
if self.curr_group == self.init_task.address:
raise StopIteration
t = self.curr_task = self.curr_group
else:
self.curr_task = \
utils.container_of(t['thread_group']['next'],
self.task_ptr_type, "thread_group")
return t
def next(self):
return self.__next__()
t = g = utils.container_of(g['tasks']['next'],
task_ptr_type, "tasks")
if t == init_task:
return
def get_task_by_pid(pid):
for task in TaskList():
for task in task_lists():
if int(task['pid']) == pid:
return task
return None