openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm/i915: Enforce execobject.alignment to be a power-of-two 

Internal requirement for the alignment is that it must be a
power-of-two, so enforce rejection at the user interface to execbuffer
(which allows the caller to specify a stricter-than-expected alignment
criterion).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Chris Wilson 2015-06-19 13:59:46 +01:00 committed by Daniel Vetter
parent 77a0d1cab4
commit 55a9785d12
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/i915/i915_gem_execbuffer.c
View File

@ -957,6 +957,9 @@ validate_exec_list(struct drm_device *dev,
if (exec[i].flags & invalid_flags) if (exec[i].flags & invalid_flags)
return -EINVAL; return -EINVAL;
if (exec[i].alignment && !is_power_of_2(exec[i].alignment))
return -EINVAL;
/* First check for malicious input causing overflow in /* First check for malicious input causing overflow in
* the worst case where we need to allocate the entire * the worst case where we need to allocate the entire
* relocation tree as a single array. * relocation tree as a single array.