dm log userspace: fix memory leak in dm_ulog_tfr_init failure path

If cn_add_callback() fails in dm_ulog_tfr_init(), it does not
deallocate prealloced memory but calls cn_del_callback().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: Jonathan Brassow <jbrassow@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
This commit is contained in:
Alexey Khoroshilov 2014-10-01 22:58:35 +02:00 committed by Mike Snitzer
parent 0e825862f3
commit 56ec16cb1e
1 changed files with 1 additions and 1 deletions

View File

@ -272,7 +272,7 @@ int dm_ulog_tfr_init(void)
r = cn_add_callback(&ulog_cn_id, "dmlogusr", cn_ulog_callback); r = cn_add_callback(&ulog_cn_id, "dmlogusr", cn_ulog_callback);
if (r) { if (r) {
cn_del_callback(&ulog_cn_id); kfree(prealloced_cn_msg);
return r; return r;
} }