openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

CRED: Fix memory leak in error handling 

Fix a memory leak on an OOM condition in prepare_usermodehelper_creds().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
This commit is contained in:
Mathieu Desnoyers 2010-03-30 00:04:00 +01:00 committed by James Morris
parent 9623e5a237
commit 570b8fb505
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kernel/cred.c
View File

@ -364,7 +364,7 @@ struct cred *prepare_usermodehelper_creds(void)
new = kmem_cache_alloc(cred_jar, GFP_ATOMIC); new = kmem_cache_alloc(cred_jar, GFP_ATOMIC);
if (!new) if (!new)
return NULL; goto free_tgcred;
kdebug("prepare_usermodehelper_creds() alloc %p", new); kdebug("prepare_usermodehelper_creds() alloc %p", new);
@ -397,6 +397,10 @@ struct cred *prepare_usermodehelper_creds(void)
error: error:
put_cred(new); put_cred(new);
free_tgcred:
#ifdef CONFIG_KEYS
kfree(tgcred);
#endif
return NULL; return NULL;
} }