openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

RDMA/vmw_pvrdma: Use zeroing memory allocator than allocator/memset 

Use dma_zalloc_coherent for allocating zeroed
memory and remove unnecessary memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Himanshu Jha 2017-12-31 17:59:00 +05:30 committed by Jason Gunthorpe
parent d78756d842
commit 583556568c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
View File

@ -882,7 +882,7 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,
dev_info(&pdev->dev, "device version %d, driver version %d\n", dev_info(&pdev->dev, "device version %d, driver version %d\n",
dev->dsr_version, PVRDMA_VERSION); dev->dsr_version, PVRDMA_VERSION);
dev->dsr = dma_alloc_coherent(&pdev->dev, sizeof(*dev->dsr), dev->dsr = dma_zalloc_coherent(&pdev->dev, sizeof(*dev->dsr),
&dev->dsrbase, GFP_KERNEL); &dev->dsrbase, GFP_KERNEL);
if (!dev->dsr) { if (!dev->dsr) {
dev_err(&pdev->dev, "failed to allocate shared region\n"); dev_err(&pdev->dev, "failed to allocate shared region\n");
@ -891,7 +891,6 @@ static int pvrdma_pci_probe(struct pci_dev *pdev,
} }
/* Setup the shared region */ /* Setup the shared region */
memset(dev->dsr, 0, sizeof(*dev->dsr));
dev->dsr->driver_version = PVRDMA_VERSION; dev->dsr->driver_version = PVRDMA_VERSION;
dev->dsr->gos_info.gos_bits = sizeof(void *) == 4 ? dev->dsr->gos_info.gos_bits = sizeof(void *) == 4 ?
PVRDMA_GOS_BITS_32 : PVRDMA_GOS_BITS_32 :