openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

mmc: host: s3cmci: no need to check return value of debugfs_create functions 

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Also, because there is no need to save the file dentries, remove them
from the host-specific structure and just recursively delete the
directory that the driver created, when shutting down.

Cc: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Greg Kroah-Hartman 2019-06-12 10:25:31 +02:00 committed by Ulf Hansson
parent fcac152782
commit 5928d8929d
2 changed files with 6 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/mmc/host/s3cmci.c
View File

@ -1452,33 +1452,18 @@ DEFINE_SHOW_ATTRIBUTE(s3cmci_regs);
static void s3cmci_debugfs_attach(struct s3cmci_host *host) static void s3cmci_debugfs_attach(struct s3cmci_host *host)
{ {
struct device *dev = &host->pdev->dev; struct device *dev = &host->pdev->dev;
struct dentry *root;
host->debug_root = debugfs_create_dir(dev_name(dev), NULL); root = debugfs_create_dir(dev_name(dev), NULL);
if (IS_ERR(host->debug_root)) { host->debug_root = root;
dev_err(dev, "failed to create debugfs root\n");
return;
}
host->debug_state = debugfs_create_file("state", 0444, debugfs_create_file("state", 0444, root, host, &s3cmci_state_fops);
host->debug_root, host, debugfs_create_file("regs", 0444, root, host, &s3cmci_regs_fops);
&s3cmci_state_fops);
if (IS_ERR(host->debug_state))
dev_err(dev, "failed to create debug state file\n");
host->debug_regs = debugfs_create_file("regs", 0444,
host->debug_root, host,
&s3cmci_regs_fops);
if (IS_ERR(host->debug_regs))
dev_err(dev, "failed to create debug regs file\n");
} }
static void s3cmci_debugfs_remove(struct s3cmci_host *host) static void s3cmci_debugfs_remove(struct s3cmci_host *host)
{ {
debugfs_remove(host->debug_regs); debugfs_remove_recursive(host->debug_root);
debugfs_remove(host->debug_state);
debugfs_remove(host->debug_root);
} }
#else #else

2
drivers/mmc/host/s3cmci.h
View File

@ -70,8 +70,6 @@ struct s3cmci_host {
#ifdef CONFIG_DEBUG_FS #ifdef CONFIG_DEBUG_FS
struct dentry *debug_root; struct dentry *debug_root;
struct dentry *debug_state;
struct dentry *debug_regs;
#endif #endif
#ifdef CONFIG_ARM_S3C24XX_CPUFREQ #ifdef CONFIG_ARM_S3C24XX_CPUFREQ