openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

x86/asm/suspend: Drop ENTRY from local data 

ENTRY is intended for functions and shall be paired with ENDPROC. ENTRY
also aligns symbols which creates unnecessary holes between data.

So drop ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64,
as these symbols are local only.

One could've used SYM_DATA_LOCAL for these symbols, but it was
discouraged earlier:

  https://lkml.kernel.org/r/20170427124310.GC23352@amd

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Len Brown <len.brown@intel.com>
Cc: linux-arch@vger.kernel.org
Cc: linux-pm@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Link: https://lkml.kernel.org/r/20190130124711.12463-3-jslaby@suse.cz
This commit is contained in:
Jiri Slaby 2019-01-30 13:46:45 +01:00 committed by Borislav Petkov
parent fab940755d
commit 5a064d398f
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/x86/kernel/acpi/wakeup_32.S
View File

@ -90,7 +90,7 @@ ret_point:
.data .data
ALIGN ALIGN
ENTRY(saved_magic) .long 0 ENTRY(saved_magic) .long 0
ENTRY(saved_eip) .long 0 saved_eip: .long 0
# saved registers # saved registers
saved_idt: .long 0,0 saved_idt: .long 0,0

12
arch/x86/kernel/acpi/wakeup_64.S
View File

@ -125,12 +125,12 @@ ENTRY(do_suspend_lowlevel)
ENDPROC(do_suspend_lowlevel) ENDPROC(do_suspend_lowlevel)
.data .data
ENTRY(saved_rbp) .quad 0 saved_rbp: .quad 0
ENTRY(saved_rsi) .quad 0 saved_rsi: .quad 0
ENTRY(saved_rdi) .quad 0 saved_rdi: .quad 0
ENTRY(saved_rbx) .quad 0 saved_rbx: .quad 0
ENTRY(saved_rip) .quad 0 saved_rip: .quad 0
ENTRY(saved_rsp) .quad 0 saved_rsp: .quad 0
ENTRY(saved_magic) .quad 0 ENTRY(saved_magic) .quad 0