openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

USB: cxacru: check data length is not negative 

When attempting to read data that is not actually
an array of values, the length may be negative
which causes an Oops due to a likely access off
the end of the data array.

This bug should not occur under normal use unless
the device returns an invalid response.

Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Simon Arlott 2009-11-21 15:07:14 +00:00 committed by Greg Kroah-Hartman
parent 1bfbd283cd
commit 5d0a9c7932
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/atm/cxacru.c
View File

@ -596,7 +596,7 @@ static int cxacru_cm_get_array(struct cxacru_data *instance, enum cxacru_cm_requ
len = ret / 4; len = ret / 4;
for (offb = 0; offb < len; ) { for (offb = 0; offb < len; ) {
int l = le32_to_cpu(buf[offb++]); int l = le32_to_cpu(buf[offb++]);
if (l > stride || l > (len - offb) / 2) { if (l < 0 || l > stride || l > (len - offb) / 2) {
if (printk_ratelimit()) if (printk_ratelimit())
usb_err(instance->usbatm, "invalid data length from cm %#x: %d\n", usb_err(instance->usbatm, "invalid data length from cm %#x: %d\n",
cm, l); cm, l);