mirror of https://gitee.com/openkylin/linux.git
nfp: populate bus-info on representors
We used to leave bus-info in ethtool driver info empty for representors in case multi-PCIe-to-single-host cards make the association between PCIe device and NFP many to one. It seems these attempts are futile, we need to link the representors to one PCIe device in sysfs to get consistent naming, plus devlink uses one PCIe as a handle, anyway. The multi-PCIe-to-single-system support won't be clean, if it ever comes. Turns out some user space (RHEL tests) likes to read bus-info so just populate it. While at it remove unnecessary app NULL-check, representors are spawned by an app, so it must exist. Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
d387b8a19a
commit
5d4b0b4068
|
@ -233,12 +233,10 @@ nfp_net_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
|
|||
static void
|
||||
nfp_app_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo)
|
||||
{
|
||||
struct nfp_app *app;
|
||||
|
||||
app = nfp_app_from_netdev(netdev);
|
||||
if (!app)
|
||||
return;
|
||||
struct nfp_app *app = nfp_app_from_netdev(netdev);
|
||||
|
||||
strlcpy(drvinfo->bus_info, pci_name(app->pdev),
|
||||
sizeof(drvinfo->bus_info));
|
||||
nfp_get_drvinfo(app, app->pdev, "*", drvinfo);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue