openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

tty: serial: jsm_tty: constify uart_ops structures 

Check for uart_ops structures that are only stored in the ops field of a
uart_port structure.  This field is declared const, so uart_ops structures
that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct uart_ops i@p = { ... };

@ok@
identifier r.i;
struct uart_port e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct uart_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct uart_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Julia Lawall 2016-09-01 19:51:34 +02:00 committed by Greg Kroah-Hartman
parent 1f1d8703a0
commit 5d9b9530e3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/jsm/jsm_tty.c
View File

@ -346,7 +346,7 @@ static void jsm_config_port(struct uart_port *port, int flags)
port->type = PORT_JSM; port->type = PORT_JSM;
} }
static struct uart_ops jsm_ops = { static const struct uart_ops jsm_ops = {
.tx_empty = jsm_tty_tx_empty, .tx_empty = jsm_tty_tx_empty,
.set_mctrl = jsm_tty_set_mctrl, .set_mctrl = jsm_tty_set_mctrl,
.get_mctrl = jsm_tty_get_mctrl, .get_mctrl = jsm_tty_get_mctrl,