openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

cxgb4: fix missing break in switch and indent return statements 

The break statement for the Macronix case is missing and will
fall through to the Winbond case and re-assign the size setting.
Fix this by adding the missing break statement.  Also correctly
indent the return statements.

Detected by CoverityScan, CID#1458020 ("Missing break in switch")

Fixes: 96ac18f14a ("cxgb4: Add support for new flash parts")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Colin Ian King 2017-10-13 17:29:00 +01:00 committed by David S. Miller
parent ae96d3331e
commit 5dc874252f
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c
View File

@ -8404,7 +8404,7 @@ static int t4_get_flash_params(struct adapter *adap)
default: default:
dev_err(adap->pdev_dev, "Micron Flash Part has bad size, ID = %#x, Density code = %#x\n", dev_err(adap->pdev_dev, "Micron Flash Part has bad size, ID = %#x, Density code = %#x\n",
flashid, density); flashid, density);
return -EINVAL; return -EINVAL;
} }
break; break;
} }
@ -8423,8 +8423,9 @@ static int t4_get_flash_params(struct adapter *adap)
default: default:
dev_err(adap->pdev_dev, "Macronix Flash Part has bad size, ID = %#x, Density code = %#x\n", dev_err(adap->pdev_dev, "Macronix Flash Part has bad size, ID = %#x, Density code = %#x\n",
flashid, density); flashid, density);
return -EINVAL; return -EINVAL;
} }
break;
} }
case 0xef: { /* Winbond */ case 0xef: { /* Winbond */
/* This Density -> Size decoding table is taken from Winbond /* This Density -> Size decoding table is taken from Winbond
@ -8441,7 +8442,7 @@ static int t4_get_flash_params(struct adapter *adap)
default: default:
dev_err(adap->pdev_dev, "Winbond Flash Part has bad size, ID = %#x, Density code = %#x\n", dev_err(adap->pdev_dev, "Winbond Flash Part has bad size, ID = %#x, Density code = %#x\n",
flashid, density); flashid, density);
return -EINVAL; return -EINVAL;
} }
break; break;
} }