openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

scsi: pmcraid: mark symbols static where possible 

We get 4 warnings about global functions without a declaration
in the scsi pmcraid driver when building with W=1:
drivers/scsi/pmcraid.c:309:6: warning: no previous prototype for 'pmcraid_init_cmdblk' [-Wmissing-prototypes]
drivers/scsi/pmcraid.c:404:6: warning: no previous prototype for 'pmcraid_return_cmd' [-Wmissing-prototypes]
drivers/scsi/pmcraid.c:1713:6: warning: no previous prototype for 'pmcraid_ioasc_logger' [-Wmissing-prototypes]
drivers/scsi/pmcraid.c:3141:1: warning: no previous prototype for 'pmcraid_init_ioadls' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which it is
declared and don't need a declaration, but can be made static.  so this
patch marks it 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Baoyou Xie 2016-08-27 23:49:24 +08:00 committed by Martin K. Petersen
parent f6dbe38edf
commit 61b96d5b68
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/scsi/pmcraid.c
View File

@ -306,7 +306,7 @@ static int pmcraid_change_queue_depth(struct scsi_device *scsi_dev, int depth)
* Return Value * Return Value
* None * None
*/ */
void pmcraid_init_cmdblk(struct pmcraid_cmd *cmd, int index) static void pmcraid_init_cmdblk(struct pmcraid_cmd *cmd, int index)
{ {
struct pmcraid_ioarcb *ioarcb = &(cmd->ioa_cb->ioarcb); struct pmcraid_ioarcb *ioarcb = &(cmd->ioa_cb->ioarcb);
dma_addr_t dma_addr = cmd->ioa_cb_bus_addr; dma_addr_t dma_addr = cmd->ioa_cb_bus_addr;
@ -401,7 +401,7 @@ static struct pmcraid_cmd *pmcraid_get_free_cmd(
* Return Value: * Return Value:
* nothing * nothing
*/ */
void pmcraid_return_cmd(struct pmcraid_cmd *cmd) static void pmcraid_return_cmd(struct pmcraid_cmd *cmd)
{ {
struct pmcraid_instance *pinstance = cmd->drv_inst; struct pmcraid_instance *pinstance = cmd->drv_inst;
unsigned long lock_flags; unsigned long lock_flags;
@ -1710,7 +1710,7 @@ static struct pmcraid_ioasc_error *pmcraid_get_error_info(u32 ioasc)
* @ioasc: ioasc code * @ioasc: ioasc code
* @cmd: pointer to command that resulted in 'ioasc' * @cmd: pointer to command that resulted in 'ioasc'
*/ */
void pmcraid_ioasc_logger(u32 ioasc, struct pmcraid_cmd *cmd) static void pmcraid_ioasc_logger(u32 ioasc, struct pmcraid_cmd *cmd)
{ {
struct pmcraid_ioasc_error *error_info = pmcraid_get_error_info(ioasc); struct pmcraid_ioasc_error *error_info = pmcraid_get_error_info(ioasc);
@ -3137,7 +3137,7 @@ static int pmcraid_eh_host_reset_handler(struct scsi_cmnd *scmd)
* returns pointer pmcraid_ioadl_desc, initialized to point to internal * returns pointer pmcraid_ioadl_desc, initialized to point to internal
* or external IOADLs * or external IOADLs
*/ */
struct pmcraid_ioadl_desc * static struct pmcraid_ioadl_desc *
pmcraid_init_ioadls(struct pmcraid_cmd *cmd, int sgcount) pmcraid_init_ioadls(struct pmcraid_cmd *cmd, int sgcount)
{ {
struct pmcraid_ioadl_desc *ioadl; struct pmcraid_ioadl_desc *ioadl;