openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

iio: Replace printk in __iio_update_buffers with dev_dbg 

While more verbose error messages are useful for debugging we should really
not put those error messages into the kernel log for normal errors that are
already reported to the application via the error code, when running in
non-debug mode.

Otherwise application authors might expect that this is part of the ABI and
to get the error they should scan the kernel log. Which would be rather
error prone itself since there is no direct mapping between a operation and
the error message so it is impossible to find out which error message
belongs to which error.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Lars-Peter Clausen 2015-05-13 16:04:44 +02:00 committed by Jonathan Cameron
parent b87b0c0f81
commit 63223c5f5c
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/iio/industrialio-buffer.c
View File

@ -663,7 +663,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
if (indio_dev->setup_ops->preenable) { if (indio_dev->setup_ops->preenable) {
ret = indio_dev->setup_ops->preenable(indio_dev); ret = indio_dev->setup_ops->preenable(indio_dev);
if (ret) { if (ret) {
printk(KERN_ERR dev_dbg(&indio_dev->dev,
"Buffer not started: buffer preenable failed (%d)\n", ret); "Buffer not started: buffer preenable failed (%d)\n", ret);
goto error_remove_inserted; goto error_remove_inserted;
} }
@ -677,7 +677,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
if (buffer->access->request_update) { if (buffer->access->request_update) {
ret = buffer->access->request_update(buffer); ret = buffer->access->request_update(buffer);
if (ret) { if (ret) {
printk(KERN_INFO dev_dbg(&indio_dev->dev,
"Buffer not started: buffer parameter update failed (%d)\n", ret); "Buffer not started: buffer parameter update failed (%d)\n", ret);
goto error_run_postdisable; goto error_run_postdisable;
} }
@ -688,7 +688,9 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
->update_scan_mode(indio_dev, ->update_scan_mode(indio_dev,
indio_dev->active_scan_mask); indio_dev->active_scan_mask);
if (ret < 0) { if (ret < 0) {
printk(KERN_INFO "Buffer not started: update scan mode failed (%d)\n", ret); dev_dbg(&indio_dev->dev,
"Buffer not started: update scan mode failed (%d)\n",
ret);
goto error_run_postdisable; goto error_run_postdisable;
} }
} }
@ -702,7 +704,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
} else { /* Should never be reached */ } else { /* Should never be reached */
/* Can only occur on first buffer */ /* Can only occur on first buffer */
if (indio_dev->modes & INDIO_BUFFER_TRIGGERED) if (indio_dev->modes & INDIO_BUFFER_TRIGGERED)
pr_info("Buffer not started: no trigger\n"); dev_dbg(&indio_dev->dev, "Buffer not started: no trigger\n");
ret = -EINVAL; ret = -EINVAL;
goto error_run_postdisable; goto error_run_postdisable;
} }
@ -710,7 +712,7 @@ static int __iio_update_buffers(struct iio_dev *indio_dev,
if (indio_dev->setup_ops->postenable) { if (indio_dev->setup_ops->postenable) {
ret = indio_dev->setup_ops->postenable(indio_dev); ret = indio_dev->setup_ops->postenable(indio_dev);
if (ret) { if (ret) {
printk(KERN_INFO dev_dbg(&indio_dev->dev,
"Buffer not started: postenable failed (%d)\n", ret); "Buffer not started: postenable failed (%d)\n", ret);
indio_dev->currentmode = INDIO_DIRECT_MODE; indio_dev->currentmode = INDIO_DIRECT_MODE;
if (indio_dev->setup_ops->postdisable) if (indio_dev->setup_ops->postdisable)