openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

cpufreq: intel_pstate: Drop pointless initialization of PID parameters 

The P-state selection algorithm used by intel_pstate for Atom
processors is not based on the PID controller and the initialization
of PID parametrs for those processors is pointless and confusing, so
drop it.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
This commit is contained in:
Rafael J. Wysocki 2017-03-28 00:04:30 +02:00
parent e14cf8857e
commit 6404367862
1 changed files with 2 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/cpufreq/intel_pstate.c
View File

@ -1540,14 +1540,6 @@ static struct cpu_defaults core_params = {
}; };
static const struct cpu_defaults silvermont_params = { static const struct cpu_defaults silvermont_params = {
.pid_policy = {
.sample_rate_ms = 10,
.deadband = 0,
.setpoint = 60,
.p_gain_pct = 14,
.d_gain_pct = 0,
.i_gain_pct = 4,
},
.funcs = { .funcs = {
.get_max = atom_get_max_pstate, .get_max = atom_get_max_pstate,
.get_max_physical = atom_get_max_pstate, .get_max_physical = atom_get_max_pstate,
@ -1561,14 +1553,6 @@ static const struct cpu_defaults silvermont_params = {
}; };
static const struct cpu_defaults airmont_params = { static const struct cpu_defaults airmont_params = {
.pid_policy = {
.sample_rate_ms = 10,
.deadband = 0,
.setpoint = 60,
.p_gain_pct = 14,
.d_gain_pct = 0,
.i_gain_pct = 4,
},
.funcs = { .funcs = {
.get_max = atom_get_max_pstate, .get_max = atom_get_max_pstate,
.get_max_physical = atom_get_max_pstate, .get_max_physical = atom_get_max_pstate,
@ -1602,14 +1586,6 @@ static const struct cpu_defaults knl_params = {
}; };
static const struct cpu_defaults bxt_params = { static const struct cpu_defaults bxt_params = {
.pid_policy = {
.sample_rate_ms = 10,
.deadband = 0,
.setpoint = 60,
.p_gain_pct = 14,
.d_gain_pct = 0,
.i_gain_pct = 4,
},
.funcs = { .funcs = {
.get_max = core_get_max_pstate, .get_max = core_get_max_pstate,
.get_max_physical = core_get_max_pstate_physical, .get_max_physical = core_get_max_pstate_physical,
@ -2637,9 +2613,9 @@ static int __init intel_pstate_init(void)
return -ENODEV; return -ENODEV;
cpu_def = (struct cpu_defaults *)id->driver_data; cpu_def = (struct cpu_defaults *)id->driver_data;
copy_pid_params(&cpu_def->pid_policy);
copy_cpu_funcs(&cpu_def->funcs); copy_cpu_funcs(&cpu_def->funcs);
if (pstate_funcs.get_target_pstate == get_target_pstate_use_performance)
copy_pid_params(&cpu_def->pid_policy);
} }
if (intel_pstate_msrs_not_valid()) if (intel_pstate_msrs_not_valid())