openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ieee1394: raw1394: Do not leak memory on failed trylock. 

Do not leak the allocated memory in case the mutex_trylock() failed
to acquire the lock.

Signed-off-by: Michael Buesch <mb@bu3sch.de>

This bug does not happen in practice:  All raw1394 clients use
libraw1394, and accesses to a libraw1394 handle need to be serialized
by the client.  This is documented in libraw1394's API reference.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
This commit is contained in:
Michael Buesch 2009-07-19 21:40:39 +02:00 committed by Stefan Richter
parent 74fca6a428
commit 64549e9357
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ieee1394/raw1394.c
View File

@ -2272,8 +2272,10 @@ static ssize_t raw1394_write(struct file *file, const char __user * buffer,
return -EFAULT;
}
if (!mutex_trylock(&fi->state_mutex))
if (!mutex_trylock(&fi->state_mutex)) {
free_pending_request(req);
return -EAGAIN;
}
switch (fi->state) {
case opened: