openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: pi433: fix potential null dereference 

Add a test for successful call to cdev_alloc() to avoid
potential null dereference. Issue reported by smatch.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Fixes: 874bcba65f ("staging: pi433: New driver")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Michael Straube 2018-11-25 10:22:25 +01:00 committed by Greg Kroah-Hartman
parent 2a68ead3de
commit 64c4c4ca6c
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/pi433/pi433_if.c
View File

@ -1245,6 +1245,10 @@ static int pi433_probe(struct spi_device *spi)
/* create cdev */ /* create cdev */
device->cdev = cdev_alloc(); device->cdev = cdev_alloc();
if (!device->cdev) {
dev_dbg(device->dev, "allocation of cdev failed");
goto cdev_failed;
}
device->cdev->owner = THIS_MODULE; device->cdev->owner = THIS_MODULE;
cdev_init(device->cdev, &pi433_fops); cdev_init(device->cdev, &pi433_fops);
retval = cdev_add(device->cdev, device->devt, 1); retval = cdev_add(device->cdev, device->devt, 1);