openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: speakup: cleanup spk_var_header_by_name() 

There is a confusing while loop here and I have re-written it in
canonical for loop format.  Also I reversed the NULL check on "name" and
pulled everything in one tab stop.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2013-05-09 21:31:59 +03:00 committed by Greg Kroah-Hartman
parent d33bce313c
commit 65545eaea9
1 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/staging/speakup/varhandlers.c
View File

@ -137,18 +137,15 @@ struct st_var_header *spk_get_var_header(enum var_id_t var_id)
struct st_var_header *spk_var_header_by_name(const char *name)
{
int i;
struct st_var_header *where = NULL;
if (name != NULL) {
i = 0;
while ((i < MAXVARS) && (where == NULL)) {
if (strcmp(name, var_ptrs[i]->name) == 0)
where = var_ptrs[i];
else
i++;
}
if (!name)
return NULL;
for (i = 0; i < MAXVARS; i++) {
if (strcmp(name, var_ptrs[i]->name) == 0)
return var_ptrs[i];
}
return where;
return NULL;
}
struct var_t *spk_get_var(enum var_id_t var_id)