openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: unisys: visorbus: device_changestate_responder add error handling 

Pass the error returned from visorchannel_signalinsert up the stack
instead of just ignoring it.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
David Kershner 2016-11-21 12:15:50 -05:00 committed by Greg Kroah-Hartman
parent 734ad93a23
commit 68f99d4911
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/staging/unisys/visorbus/visorchipset.c
View File

@ -652,7 +652,7 @@ bus_responder(enum controlvm_id cmd_id,
return controlvm_respond(pending_msg_hdr, response); return controlvm_respond(pending_msg_hdr, response);
} }
static void static int
device_changestate_responder(enum controlvm_id cmd_id, device_changestate_responder(enum controlvm_id cmd_id,
struct visor_device *p, int response, struct visor_device *p, int response,
struct spar_segment_state response_state) struct spar_segment_state response_state)
@ -662,9 +662,9 @@ device_changestate_responder(enum controlvm_id cmd_id,
u32 dev_no = p->chipset_dev_no; u32 dev_no = p->chipset_dev_no;
if (!p->pending_msg_hdr) if (!p->pending_msg_hdr)
return; /* no controlvm response needed */ return -EIO;
if (p->pending_msg_hdr->id != cmd_id) if (p->pending_msg_hdr->id != cmd_id)
return; return -EINVAL;
controlvm_init_response(&outmsg, p->pending_msg_hdr, response); controlvm_init_response(&outmsg, p->pending_msg_hdr, response);
@ -672,9 +672,8 @@ device_changestate_responder(enum controlvm_id cmd_id,
outmsg.cmd.device_change_state.dev_no = dev_no; outmsg.cmd.device_change_state.dev_no = dev_no;
outmsg.cmd.device_change_state.state = response_state; outmsg.cmd.device_change_state.state = response_state;
if (visorchannel_signalinsert(controlvm_channel, return visorchannel_signalinsert(controlvm_channel,
CONTROLVM_QUEUE_REQUEST, &outmsg)) CONTROLVM_QUEUE_REQUEST, &outmsg);
return;
} }
static void static void