openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

p54spi: cosmetic fixes: use even byte count in SPI write; drop unused interrupt status read 

When SPI write of odd length is requested, p54spi_write splits it
into two parts: one for all data, except the last byte, and one
for last byte and padding byte. Unfortunately, the length of
first part is not amended. It works because all meaningful bytes
have proper value and the last byte of odd length SPI write
transaction is ignored.

p54spi_work has dummy HOST_INTERRUPTS register read at the end.
Drop it, as its result is not used and it has no side effects.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Max Filippov 2009-05-18 03:02:32 +04:00 committed by John W. Linville
parent 210dd1bb9b
commit 69712e926b
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/wireless/p54/p54spi.c
View File

@ -96,7 +96,7 @@ static void p54spi_spi_write(struct p54s_priv *priv, u8 address,
spi_message_add_tail(&t[0], &m);
t[1].tx_buf = buf;
t[1].len = len;
t[1].len = len & ~1;
spi_message_add_tail(&t[1], &m);
if (len % 2) {
@ -541,11 +541,6 @@ static void p54spi_work(struct work_struct *work)
}
ret = p54spi_wq_tx(priv);
if (ret < 0)
goto out;
ints = p54spi_read32(priv, SPI_ADRS_HOST_INTERRUPTS);
out:
mutex_unlock(&priv->mutex);
}