mirror of https://gitee.com/openkylin/linux.git
dmaengine: qcom_hidma: fix return value check in hidma_mgmt_of_populate_channels()
In case of error, the function platform_device_register_full() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
This commit is contained in:
parent
d3183447ef
commit
6a2cf55db3
|
@ -371,8 +371,8 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
|
|||
pdevinfo.size_data = 0;
|
||||
pdevinfo.dma_mask = DMA_BIT_MASK(64);
|
||||
new_pdev = platform_device_register_full(&pdevinfo);
|
||||
if (!new_pdev) {
|
||||
ret = -ENODEV;
|
||||
if (IS_ERR(new_pdev)) {
|
||||
ret = PTR_ERR(new_pdev);
|
||||
goto out;
|
||||
}
|
||||
of_dma_configure(&new_pdev->dev, child);
|
||||
|
|
Loading…
Reference in New Issue