openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

[CONNECTOR]: Cleanup struct cn_callback_entry 

- 'cb' is a fake struct member. In a previous patch struct cn_callback
was renamed to cn_callback_id, so 'cb' should have been deleted at that
time.

- 'nls' isn't used and is redundant, we can retrieve this data through
cn_callback_entry.pdev->nls.

- 'seq' and 'group' should be u32, as they are declared to be u32 in
other places.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Li Zefan 2008-01-04 01:59:42 -08:00 committed by David S. Miller
parent 96a899655e
commit 6e32814bc8
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/connector/cn_queue.c
View File

@ -104,7 +104,6 @@ int cn_queue_add_callback(struct cn_queue_dev *dev, char *name, struct cb_id *id
return -EINVAL; return -EINVAL;
} }
cbq->nls = dev->nls;
cbq->seq = 0; cbq->seq = 0;
cbq->group = cbq->id.id.idx; cbq->group = cbq->id.id.idx;

4
include/linux/connector.h
View File

@ -132,15 +132,13 @@ struct cn_callback_data {
struct cn_callback_entry { struct cn_callback_entry {
struct list_head callback_entry; struct list_head callback_entry;
struct cn_callback *cb;
struct work_struct work; struct work_struct work;
struct cn_queue_dev *pdev; struct cn_queue_dev *pdev;
struct cn_callback_id id; struct cn_callback_id id;
struct cn_callback_data data; struct cn_callback_data data;
int seq, group; u32 seq, group;
struct sock *nls;
}; };
struct cn_ctl_entry { struct cn_ctl_entry {