openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

fs: dlm: check on minimum msglen size 

This patch adds an additional check for minimum dlm header size which is
an invalid dlm message and signals a broken stream. A msglen field cannot
be less than the dlm header size because the field is inclusive header
lengths.

Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
This commit is contained in:
Alexander Aring 2021-03-01 17:05:17 -05:00 committed by David Teigland
parent f0747ebf48
commit 710176e836
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/dlm/midcomms.c
View File

@ -49,9 +49,10 @@ int dlm_process_incoming_buffer(int nodeid, unsigned char *buf, int len)
* cannot deliver this message to upper layers * cannot deliver this message to upper layers
*/ */
msglen = get_unaligned_le16(&hd->h_length); msglen = get_unaligned_le16(&hd->h_length);
if (msglen > DEFAULT_BUFFER_SIZE) { if (msglen > DEFAULT_BUFFER_SIZE ||
log_print("received invalid length header: %u, will abort message parsing", msglen < sizeof(struct dlm_header)) {
msglen); log_print("received invalid length header: %u from node %d, will abort message parsing",
msglen, nodeid);
return -EBADMSG; return -EBADMSG;
} }