openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

[media] Staging: media: radio-bcm2048: remove incorrect __exit markups 

Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Dmitry Torokhov 2017-03-01 20:50:03 -03:00 committed by Mauro Carvalho Chehab
parent 78cea55c60
commit 733e009c37
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/media/bcm2048/radio-bcm2048.c
View File

@ -2642,7 +2642,7 @@ static int bcm2048_i2c_driver_probe(struct i2c_client *client,
return err; return err;
} }
static int __exit bcm2048_i2c_driver_remove(struct i2c_client *client) static int bcm2048_i2c_driver_remove(struct i2c_client *client)
{ {
struct bcm2048_device *bdev = i2c_get_clientdata(client); struct bcm2048_device *bdev = i2c_get_clientdata(client);
@ -2681,7 +2681,7 @@ static struct i2c_driver bcm2048_i2c_driver = {
.name = BCM2048_DRIVER_NAME, .name = BCM2048_DRIVER_NAME,
}, },
.probe = bcm2048_i2c_driver_probe, .probe = bcm2048_i2c_driver_probe,
.remove = __exit_p(bcm2048_i2c_driver_remove), .remove = bcm2048_i2c_driver_remove,
.id_table = bcm2048_id, .id_table = bcm2048_id,
}; };