openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

powerpc/pmac: Fix dangling pointers 

Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Colin Leroy <colin@colino.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
Wolfram Sang 2010-03-20 04:12:50 +00:00 committed by Benjamin Herrenschmidt
parent 21dbeb91a2
commit 7429b3842c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/macintosh/therm_adt746x.c
View File

@ -182,6 +182,7 @@ remove_thermostat(struct i2c_client *client)
thermostat = NULL; thermostat = NULL;
i2c_set_clientdata(client, NULL);
kfree(th); kfree(th);
return 0; return 0;
@ -399,6 +400,7 @@ static int probe_thermostat(struct i2c_client *client,
rc = read_reg(th, CONFIG_REG); rc = read_reg(th, CONFIG_REG);
if (rc < 0) { if (rc < 0) {
dev_err(&client->dev, "Thermostat failed to read config!\n"); dev_err(&client->dev, "Thermostat failed to read config!\n");
i2c_set_clientdata(client, NULL);
kfree(th); kfree(th);
return -ENODEV; return -ENODEV;
} }