openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

[media] go7007: don't use vb before test if it is not NULL 

As reported by smatch:
	drivers/media/usb/go7007/go7007-driver.c:452 frame_boundary() warn: variable dereferenced before check 'vb' (see line 449)

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Mauro Carvalho Chehab 2015-04-28 17:09:23 -03:00
parent efc0ac5a0e
commit 747598d5b6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/usb/go7007/go7007-driver.c
View File

@ -446,7 +446,7 @@ static void go7007_motion_regions(struct go7007 *go, struct go7007_buffer *vb)
*/ */
static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buffer *vb) static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buffer *vb)
{ {
u32 *bytesused = &vb->vb.v4l2_planes[0].bytesused; u32 *bytesused;
struct go7007_buffer *vb_tmp = NULL; struct go7007_buffer *vb_tmp = NULL;
if (vb == NULL) { if (vb == NULL) {
@ -458,6 +458,7 @@ static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buf
go->next_seq++; go->next_seq++;
return vb; return vb;
} }
bytesused = &vb->vb.v4l2_planes[0].bytesused;
vb->vb.v4l2_buf.sequence = go->next_seq++; vb->vb.v4l2_buf.sequence = go->next_seq++;
if (vb->modet_active && *bytesused + 216 < GO7007_BUF_SIZE) if (vb->modet_active && *bytesused + 216 < GO7007_BUF_SIZE)