openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Staging: gdm72xx: Remove unnecessary cast on void pointer 

void pointers do not need to be cast to other pointer types.

The semantic patch used to find this:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Shraddha Barke 2015-10-15 00:58:25 +05:30 committed by Greg Kroah-Hartman
parent e4c0c6bc0c
commit 759f19dda5
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/gdm72xx/gdm_qos.c
View File

@ -59,7 +59,7 @@ static void *alloc_qos_entry(void)
static void free_qos_entry(void *entry) static void free_qos_entry(void *entry)
{ {
struct qos_entry_s *qentry = (struct qos_entry_s *)entry; struct qos_entry_s *qentry = entry;
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&qos_free_list.lock, flags); spin_lock_irqsave(&qos_free_list.lock, flags);

14
drivers/staging/gdm72xx/gdm_wimax.c
View File

@ -339,7 +339,7 @@ static void gdm_wimax_ind_if_updown(struct net_device *dev, int if_up)
static int gdm_wimax_open(struct net_device *dev) static int gdm_wimax_open(struct net_device *dev)
{ {
struct nic *nic = netdev_priv(dev); struct nic *nic = netdev_priv(dev);
struct fsm_s *fsm = (struct fsm_s *)nic->sdk_data[SIOC_DATA_FSM].buf; struct fsm_s *fsm = nic->sdk_data[SIOC_DATA_FSM].buf;
netif_start_queue(dev); netif_start_queue(dev);
@ -351,7 +351,7 @@ static int gdm_wimax_open(struct net_device *dev)
static int gdm_wimax_close(struct net_device *dev) static int gdm_wimax_close(struct net_device *dev)
{ {
struct nic *nic = netdev_priv(dev); struct nic *nic = netdev_priv(dev);
struct fsm_s *fsm = (struct fsm_s *)nic->sdk_data[SIOC_DATA_FSM].buf; struct fsm_s *fsm = nic->sdk_data[SIOC_DATA_FSM].buf;
netif_stop_queue(dev); netif_stop_queue(dev);
@ -378,7 +378,7 @@ static int gdm_wimax_ioctl_get_data(struct data_s *dst, struct data_s *src)
if (src->size) { if (src->size) {
if (!dst->buf) if (!dst->buf)
return -EINVAL; return -EINVAL;
if (copy_to_user((void __user *)dst->buf, src->buf, size)) if (copy_to_user(dst->buf, src->buf, size))
return -EFAULT; return -EFAULT;
} }
return 0; return 0;
@ -401,7 +401,7 @@ static int gdm_wimax_ioctl_set_data(struct data_s *dst, struct data_s *src)
return -ENOMEM; return -ENOMEM;
} }
if (copy_from_user(dst->buf, (void __user *)src->buf, src->size)) { if (copy_from_user(dst->buf, src->buf, src->size)) {
kdelete(&dst->buf); kdelete(&dst->buf);
return -EFAULT; return -EFAULT;
} }
@ -435,7 +435,7 @@ static void gdm_wimax_ind_fsm_update(struct net_device *dev, struct fsm_s *fsm)
static void gdm_update_fsm(struct net_device *dev, struct fsm_s *new_fsm) static void gdm_update_fsm(struct net_device *dev, struct fsm_s *new_fsm)
{ {
struct nic *nic = netdev_priv(dev); struct nic *nic = netdev_priv(dev);
struct fsm_s *cur_fsm = (struct fsm_s *) struct fsm_s *cur_fsm =
nic->sdk_data[SIOC_DATA_FSM].buf; nic->sdk_data[SIOC_DATA_FSM].buf;
if (!cur_fsm) if (!cur_fsm)
@ -483,7 +483,7 @@ static int gdm_wimax_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
* before gdm_wimax_ioctl_set_data is called. * before gdm_wimax_ioctl_set_data is called.
*/ */
gdm_update_fsm(dev, gdm_update_fsm(dev,
(struct fsm_s *)req->data.buf); req->data.buf);
} }
ret = gdm_wimax_ioctl_set_data( ret = gdm_wimax_ioctl_set_data(
&nic->sdk_data[req->data_id], &req->data); &nic->sdk_data[req->data_id], &req->data);
@ -798,7 +798,7 @@ int register_wimax_device(struct phy_dev *phy_dev, struct device *pdev)
void unregister_wimax_device(struct phy_dev *phy_dev) void unregister_wimax_device(struct phy_dev *phy_dev)
{ {
struct nic *nic = netdev_priv(phy_dev->netdev); struct nic *nic = netdev_priv(phy_dev->netdev);
struct fsm_s *fsm = (struct fsm_s *)nic->sdk_data[SIOC_DATA_FSM].buf; struct fsm_s *fsm = nic->sdk_data[SIOC_DATA_FSM].buf;
if (fsm) if (fsm)
fsm->m_status = M_INIT; fsm->m_status = M_INIT;