openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging/rtl8192e: Erroneous return codes (types and values) 

This function returns a bool, that is supposed to be false when something
goes wrong. It's assumed this way by its lone calling function (which is
SetRFPowerState8190(), line 1445 of rtl8192e/rtl8192e/r8192E_phy.c)

Despite of this, this procedure returns non-null enumerations values or
negative codes instead. This patch fixes this.

Signed-off-by: Dominique van den Broeck <domdevlin@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dominique van den Broeck 2014-04-27 19:11:15 +02:00 committed by Greg Kroah-Hartman
parent 73fbfbfecb
commit 7626e3d0d4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
View File

@ -3029,7 +3029,7 @@ bool NicIFEnableNIC(struct net_device *dev)
RT_TRACE(COMP_ERR, "ERR!!! %s(): Driver is already down!\n", RT_TRACE(COMP_ERR, "ERR!!! %s(): Driver is already down!\n",
__func__); __func__);
priv->bdisable_nic = false; priv->bdisable_nic = false;
return RT_STATUS_FAILURE; return false;
} }
RT_TRACE(COMP_PS, "===========>%s()\n", __func__); RT_TRACE(COMP_PS, "===========>%s()\n", __func__);
@ -3039,7 +3039,7 @@ bool NicIFEnableNIC(struct net_device *dev)
RT_TRACE(COMP_ERR, "ERR!!! %s(): initialization is failed!\n", RT_TRACE(COMP_ERR, "ERR!!! %s(): initialization is failed!\n",
__func__); __func__);
priv->bdisable_nic = false; priv->bdisable_nic = false;
return -1; return false;
} }
RT_TRACE(COMP_INIT, "start adapter finished\n"); RT_TRACE(COMP_INIT, "start adapter finished\n");
RT_CLEAR_PS_LEVEL(pPSC, RT_RF_OFF_LEVL_HALT_NIC); RT_CLEAR_PS_LEVEL(pPSC, RT_RF_OFF_LEVL_HALT_NIC);