openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

nfp: allow apps to disable ctrl vNIC capabilities 

Most vNIC capabilities are netdev related.  It makes no sense
to initialize them and waste FW resources.  Some are even
counter-productive, like IRQ moderation, which will slow
down exchange of control messages.

Add to nfp_app a mask of enabled control vNIC capabilities
for apps to use.  Make flower and BPF enable all capabilities
for now.  No functional changes.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jakub Kicinski 2018-01-17 18:51:05 -08:00 committed by David S. Miller
parent 545bfa7a6a
commit 78a0a65f40
4 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/netronome/nfp/bpf/main.c
View File

@ -389,6 +389,8 @@ const struct nfp_app_type app_bpf = {
.id = NFP_APP_BPF_NIC,
.name = "ebpf",
.ctrl_cap_mask = ~0U,
.init = nfp_bpf_init,
.clean = nfp_bpf_clean,

2
drivers/net/ethernet/netronome/nfp/flower/main.c
View File

@ -565,6 +565,8 @@ static void nfp_flower_stop(struct nfp_app *app)
const struct nfp_app_type app_flower = {
.id = NFP_APP_FLOWER_NIC,
.name = "flower",
.ctrl_cap_mask = ~0U,
.ctrl_has_meta = true,
.extra_cap = nfp_flower_extra_cap,

4
drivers/net/ethernet/netronome/nfp/nfp_app.h
View File

@ -66,6 +66,9 @@ extern const struct nfp_app_type app_flower;
* struct nfp_app_type - application definition
* @id: application ID
* @name: application name
* @ctrl_cap_mask: ctrl vNIC capability mask, allows disabling features like
* IRQMOD which are on by default but counter-productive for
* control messages which are often latency-sensitive
* @ctrl_has_meta: control messages have prepend of type:5/port:CTRL
*
* Callbacks
@ -100,6 +103,7 @@ struct nfp_app_type {
enum nfp_app_id id;
const char *name;
u32 ctrl_cap_mask;
bool ctrl_has_meta;
int (*init)(struct nfp_app *app);

4
drivers/net/ethernet/netronome/nfp/nfp_net_common.c
View File

@ -3790,6 +3790,10 @@ static int nfp_net_read_caps(struct nfp_net *nn)
nn->dp.rx_offset = NFP_NET_RX_OFFSET;
}
/* For control vNICs mask out the capabilities app doesn't want. */
if (!nn->dp.netdev)
nn->cap &= nn->app->type->ctrl_cap_mask;
return 0;
}