openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: comedi: remove this_board macro in the aio_aio12_8 driver 

The 'thisboard' macro depends on having a local variable with
a magic name. The CodingStyle document suggests not doing this
to avoid confusion. Remove the macro and use the comedi_board()
inline helper to get the dev->board_ptr information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-05-22 15:46:02 -07:00 committed by Greg Kroah-Hartman
parent b74055465c
commit 797ef32ba3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/comedi/drivers/aio_aio12_8.c
View File

@ -80,8 +80,6 @@ static const struct aio12_8_boardtype board_types[] = {
.name = "aio_aio12_8"}, .name = "aio_aio12_8"},
}; };
#define thisboard ((const struct aio12_8_boardtype *) dev->board_ptr)
struct aio12_8_private { struct aio12_8_private {
unsigned int ao_readback[4]; unsigned int ao_readback[4];
}; };
@ -167,6 +165,7 @@ static const struct comedi_lrange range_aio_aio12_8 = {
static int aio_aio12_8_attach(struct comedi_device *dev, static int aio_aio12_8_attach(struct comedi_device *dev,
struct comedi_devconfig *it) struct comedi_devconfig *it)
{ {
const struct aio12_8_boardtype *board = comedi_board(dev);
int iobase; int iobase;
struct comedi_subdevice *s; struct comedi_subdevice *s;
@ -176,7 +175,7 @@ static int aio_aio12_8_attach(struct comedi_device *dev,
return -EIO; return -EIO;
} }
dev->board_name = thisboard->name; dev->board_name = board->name;
dev->iobase = iobase; dev->iobase = iobase;