openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

dyndbg: fix parsing file query without a line-range suffix 

Query like 'file tcp_input.c line 1234 +p' was broken by
commit aaebe329bf ("dyndbg: accept 'file foo.c:func1' and 'file
foo.c:10-100'") because a file name without a ':' now makes the loop in
ddebug_parse_query() exits early before parsing the 'line 1234' part.
As a result, all pr_debug() in tcp_input.c will be enabled, instead of only
the one on line 1234.  Changing 'break' to 'continue' fixes this.

Fixes: aaebe329bf ("dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100'")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Shuo Chen <shuochen@google.com>
Acked-by: Jason Baron <jbaron@akamai.com>
Link: https://lore.kernel.org/r/20210414212400.2927281-1-giantchen@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Shuo Chen 2021-04-14 14:24:00 -07:00 committed by Greg Kroah-Hartman
parent f1ce3986ba
commit 7b1ae24827
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dynamic_debug.c
View File

@ -396,7 +396,7 @@ static int ddebug_parse_query(char *words[], int nwords,
/* tail :$info is function or line-range */ /* tail :$info is function or line-range */
fline = strchr(query->filename, ':'); fline = strchr(query->filename, ':');
if (!fline) if (!fline)
break; continue;
*fline++ = '\0'; *fline++ = '\0';
if (isalpha(*fline) || *fline == '*' || *fline == '?') { if (isalpha(*fline) || *fline == '*' || *fline == '?') {
/* take as function name */ /* take as function name */