openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ext4: remove redundant operation that set bh to NULL 

The out_fail branch path don't release the bh and the second bh is
valid only in the for statement, so we don't need to set them to NULL.

Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Reviewed-by: zhangyi (F) <yi.zhang@huawei.com>
Link: https://lore.kernel.org/r/1603194069-17557-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
This commit is contained in:
Kaixu Xia 2020-10-20 19:41:09 +08:00 committed by Theodore Ts'o
parent 50a4952fd6
commit 7b721e6d33
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/ext4/super.c
View File

@ -4074,7 +4074,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
if (IS_ERR(bh)) { if (IS_ERR(bh)) {
ext4_msg(sb, KERN_ERR, "unable to read superblock"); ext4_msg(sb, KERN_ERR, "unable to read superblock");
ret = PTR_ERR(bh); ret = PTR_ERR(bh);
bh = NULL;
goto out_fail; goto out_fail;
} }
/* /*
@ -4703,7 +4702,6 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
"can't read group descriptor %d", i); "can't read group descriptor %d", i);
db_count = i; db_count = i;
ret = PTR_ERR(bh); ret = PTR_ERR(bh);
bh = NULL;
goto failed_mount2; goto failed_mount2;
} }
rcu_read_lock(); rcu_read_lock();