openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

[NETFILTER]: nfnetlink_log: fix module reference counting 

Count module references correctly: after instance_destroy() there
might be timer pending and holding a reference for this netlink instance.

Based on patch by Michal Miroslaw <mirq-linux@rere.qmqm.pl>

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Patrick McHardy 2007-03-04 15:59:45 -08:00 committed by David S. Miller
parent dd16704eba
commit 7d90e86d31
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/netfilter/nfnetlink_log.c
View File

@ -133,6 +133,7 @@ instance_put(struct nfulnl_instance *inst)
if (inst && atomic_dec_and_test(&inst->use)) { if (inst && atomic_dec_and_test(&inst->use)) {
UDEBUG("kfree(inst=%p)\n", inst); UDEBUG("kfree(inst=%p)\n", inst);
kfree(inst); kfree(inst);
module_put(THIS_MODULE);
} }
} }
@ -228,8 +229,6 @@ _instance_destroy2(struct nfulnl_instance *inst, int lock)
/* and finally put the refcount */ /* and finally put the refcount */
instance_put(inst); instance_put(inst);
module_put(THIS_MODULE);
} }
static inline void static inline void