openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

greybus: legacy: add initialized flag 

Add initialized flag and use instead of the connection protocol pointer
to determine when the legacy connection has been initialised.

This is a step in moving legacy connection binding to
connection-creation time.

Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2016-01-21 17:34:18 +01:00 committed by Greg Kroah-Hartman
parent 431b3ebb3d
commit 8278fae5d7
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/greybus/legacy.c
View File

@ -14,6 +14,7 @@
struct legacy_connection {
struct gb_connection *connection;
bool initialized;
};
struct legacy_data {
@ -112,6 +113,8 @@ static int legacy_connection_init(struct legacy_connection *lc)
if (ret)
goto err_disable;
lc->initialized = true;
return 0;
err_disable:
@ -126,7 +129,7 @@ static void legacy_connection_exit(struct legacy_connection *lc)
{
struct gb_connection *connection = lc->connection;
if (!connection->protocol)
if (!lc->initialized)
return;
gb_connection_disable(connection);
@ -134,6 +137,8 @@ static void legacy_connection_exit(struct legacy_connection *lc)
connection->protocol->connection_exit(connection);
legacy_connection_unbind_protocol(connection);
lc->initialized = false;
}
static int legacy_connection_create(struct legacy_connection *lc,