openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

staging: sbe-2t3e3: remove t3e3_tx_desc_t typedef 

Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_tx_desc_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:651: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kristina Martšenko 2014-03-03 23:05:43 +02:00 committed by Greg Kroah-Hartman
parent 692d79e179
commit 844a18cec6
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/sbe-2t3e3/2t3e3.h
View File

@ -648,12 +648,12 @@ struct t3e3_rx_desc {
/*********************/
typedef struct {
struct t3e3_tx_desc {
u32 tdes0;
u32 tdes1;
u32 tdes2;
u32 tdes3;
} t3e3_tx_desc_t;
};
#define SBE_2T3E3_TX_DESC_RING_SIZE 256
@ -728,7 +728,7 @@ struct channel {
u32 rx_ring_current_read;
/* transmit chain/ring */
t3e3_tx_desc_t *tx_ring;
struct t3e3_tx_desc *tx_ring;
struct sk_buff *tx_data[SBE_2T3E3_TX_DESC_RING_SIZE];
u32 tx_ring_current_read;
u32 tx_ring_current_write;

2
drivers/staging/sbe-2t3e3/dc.c
View File

@ -322,7 +322,7 @@ static int dc_init_descriptor_list(struct channel *sc)
if (sc->ether.tx_ring == NULL)
sc->ether.tx_ring = kcalloc(SBE_2T3E3_TX_DESC_RING_SIZE,
sizeof(t3e3_tx_desc_t), GFP_KERNEL);
sizeof(struct t3e3_tx_desc), GFP_KERNEL);
if (sc->ether.tx_ring == NULL) {
kfree(sc->ether.rx_ring);
sc->ether.rx_ring = NULL;

2
drivers/staging/sbe-2t3e3/intr.c
View File

@ -292,7 +292,7 @@ void dc_intr_tx(struct channel *sc)
{
u32 current_read, current_write;
u32 last_segment, error;
t3e3_tx_desc_t *current_desc;
struct t3e3_tx_desc *current_desc;
spin_lock(&sc->ether.tx_lock);